implement suggestions

open-telemetry · Jan 16, 2025 · c02ec91 · c02ec91
1 parent 46a5505
commit c02ec91
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/metrics_sdk/lib/opentelemetry/sdk/metrics/aggregation/sum.rb b/metrics_sdk/lib/opentelemetry/sdk/metrics/aggregation/sum.rb
@@ -40,6 +40,8 @@ def collect(start_time, end_time, data_points)
           end
 
           def update(increment, attributes, data_points)
+            return if @is_monotonic && increment < 0
+
             ndp = data_points[attributes] || data_points[attributes] = NumberDataPoint.new(
               attributes,
               nil,
@@ -48,8 +50,6 @@ def update(increment, attributes, data_points)
               nil
             )
 
-            return if is_monotonic && increment < 0
-
             ndp.value += increment
             nil
           end

diff --git a/metrics_sdk/lib/opentelemetry/sdk/metrics/state/metric_stream.rb b/metrics_sdk/lib/opentelemetry/sdk/metrics/state/metric_stream.rb
@@ -67,7 +67,7 @@ def update(value, attributes)
 
           def aggregate_metric_data(start_time, end_time, aggregation: nil)
             aggregator = aggregation || @default_aggregation
-            is_monotonic = aggregator.respond_to?(:is_monotonic) && aggregator.is_monotonic
+            is_monotonic = aggregator.respond_to?(:is_monotonic) ? aggregator.is_monotonic : nil
 
             MetricData.new(
               @name,