Fix api tests for real

open-telemetry · Jan 17, 2025 · 103f285 · 103f285
1 parent c595be1
commit 103f285
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/opentelemetry-api/tests/metrics/test_meter.py b/opentelemetry-api/tests/metrics/test_meter.py
@@ -85,7 +85,7 @@ class TestMeter(TestCase):
     # TODO: convert to assertNoLogs instead of mocking logger when 3.10 is baseline
     @patch("opentelemetry.metrics._internal._logger")
     def test_repeated_instrument_names(self, logger_mock):
-        with self.assertNotRaises(Exception):
+        try:
             test_meter = NoOpMeter("name")
 
             test_meter.create_counter("counter")
@@ -97,6 +97,8 @@ def test_repeated_instrument_names(self, logger_mock):
             test_meter.create_observable_up_down_counter(
                 "observable_up_down_counter", Mock()
             )
+        except Exception as error:  # pylint: disable=broad-exception-caught
+            self.fail(f"Unexpected exception raised {error}")
 
         for instrument_name in [
             "counter",
@@ -118,7 +120,7 @@ def test_repeated_instrument_names(self, logger_mock):
             logger_mock.warning.assert_not_called()
 
     def test_repeated_instrument_names_with_different_advisory(self):
-        with self.assertNotRaises(Exception):
+        try:
             test_meter = NoOpMeter("name")
 
             test_meter.create_counter("counter")
@@ -130,6 +132,8 @@ def test_repeated_instrument_names_with_different_advisory(self):
             test_meter.create_observable_up_down_counter(
                 "observable_up_down_counter", Mock()
             )
+        except Exception as error:  # pylint: disable=broad-exception-caught
+            self.fail(f"Unexpected exception raised {error}")
 
         for instrument_name in [
             "counter",