-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:(instrumentation-http) Capture Synthetic Source Type on Requests #5488
Open
JacksonWeber
wants to merge
13
commits into
open-telemetry:main
Choose a base branch
from
JacksonWeber:jacksonweber/(feat)-add-synthetic-source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat:(instrumentation-http) Capture Synthetic Source Type on Requests #5488
JacksonWeber
wants to merge
13
commits into
open-telemetry:main
from
JacksonWeber:jacksonweber/(feat)-add-synthetic-source
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5488 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 308 308
Lines 7928 7928
Branches 1604 1604
=======================================
Hits 7528 7528
Misses 400 400 |
(Aside: Eww. I just had my first data loss with GitHub forms. I had a couple comments in pending review, then the PR was updated with new commits, then I hit the GitHub "refresh" link to update the PR diff and it lost my pending review comments.) |
trentm
requested changes
Feb 26, 2025
experimental/packages/opentelemetry-instrumentation-http/src/internal-types.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Trent Mick <trentm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
Adds support for marking bot/test traffic as synthetic based on the
user-agent
header.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
user-agent
header are marked as synthetic.Checklist: