Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-trace): make activeSpanProcessor private #4965

Conversation

legalimpurity
Copy link
Contributor

@legalimpurity legalimpurity commented Aug 29, 2024

Which problem is this PR solving?

This addresses the issue of making activeSpanProcessor private.
Fixes #4792

Short description of the changes

Makes activeSpanProcessor private in BasicTracerProvider.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

A few tests that were accessing the property have been fixed.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@legalimpurity legalimpurity requested a review from a team August 29, 2024 17:57
@pichlermarc
Copy link
Member

Hi, thanks for working on this, would you mind chaging the target to the next branch and rebasing the changes onto next 🙂

All breaking changes from the SDK 2.0 Milestone usually go onto the next branch 🙂

@legalimpurity legalimpurity changed the base branch from main to next August 30, 2024 14:41
@pichlermarc
Copy link
Member

@legalimpurity would you mind just rebasing your two commits onto the current next branch? then we can proceed with the review 🙂

@pichlermarc pichlermarc requested a review from a team September 26, 2024 08:00
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (32564ad) to head (2175676).
Report is 4 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #4965   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files         310      310           
  Lines        8147     8147           
  Branches     1630     1630           
=======================================
  Hits         7655     7655           
  Misses        492      492           
Files with missing lines Coverage Δ
...elemetry-sdk-trace-base/src/BasicTracerProvider.ts 95.53% <ø> (ø)

@pichlermarc pichlermarc merged commit 98143af into open-telemetry:next Sep 27, 2024
18 checks passed
@legalimpurity legalimpurity deleted the fix/makeActiveSpanProcessorPrivate branch November 27, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk-trace] make activeSpanProcessor private
3 participants