refactor: Adds AbstractBasicTracerFactory, all factories extend from …

…that

packages/opentelemetry-node/src/NodeTracerFactory.ts

@@ -14,36 +14,22 @@
  * limitations under the License.
  */
 
-import * as types from '@opentelemetry/types';
 import { NodeTracer } from './NodeTracer';
 import { NodeTracerConfig } from './config';
-import { SpanProcessor } from '@opentelemetry/tracing';
+import {
+  BasicTracer,
+  AbstractBasicTracerFactory,
+} from '@opentelemetry/tracing';
 
-export class NodeTracerFactory implements types.TracerFactory {
-  private readonly _tracers: Map<string, NodeTracer> = new Map();
-  private _spanProcessors: SpanProcessor[] = [];
+export class NodeTracerFactory extends AbstractBasicTracerFactory {
   private readonly _config?: NodeTracerConfig;
 
   constructor(config?: NodeTracerConfig) {
+    super();
     this._config = config;
   }
 
-  addSpanProcessor(processor: SpanProcessor): void {
-    this._spanProcessors.push(processor);
-    for (const tracer of this._tracers.values()) {
-      tracer.addSpanProcessor(processor);
-    }
-  }
-
-  getTracer(name: string = '', version?: string): types.Tracer {
-    const key = name + (version != undefined ? version : '');
-    if (this._tracers.has(key)) return this._tracers.get(key)!;
-
-    const tracer = new NodeTracer(this._config);
-    for (const processor of this._spanProcessors) {
-      tracer.addSpanProcessor(processor);
-    }
-    this._tracers.set(key, tracer);
-    return tracer;
+  protected _newTracer(): BasicTracer {
+    return new NodeTracer(this._config);
   }
 }

packages/opentelemetry-tracing/src/AbstractBasicTracerFactory.ts

@@ -0,0 +1,46 @@
+/*!
+ * Copyright 2019, OpenTelemetry Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import * as types from '@opentelemetry/types';
+import { BasicTracer } from './BasicTracer';
+import { SpanProcessor } from './SpanProcessor';
+
+export abstract class AbstractBasicTracerFactory
+  implements types.TracerFactory {
+  protected readonly _tracers: Map<string, BasicTracer> = new Map();
+  protected _spanProcessors: SpanProcessor[] = [];
+
+  addSpanProcessor(spanProcessor: SpanProcessor): void {
+    this._spanProcessors.push(spanProcessor);
+    for (const tracer of this._tracers.values()) {
+      tracer.addSpanProcessor(spanProcessor);
+    }
+  }
+
+  getTracer(name: string = '', version?: string): types.Tracer {
+    const key = name + (version != undefined ? version : '');
+    if (this._tracers.has(key)) return this._tracers.get(key)!;
+
+    const tracer = this._newTracer();
+    for (const processor of this._spanProcessors) {
+      tracer.addSpanProcessor(processor);
+    }
+    this._tracers.set(key, tracer);
+    return tracer;
+  }
+
+  protected abstract _newTracer(): BasicTracer;
+}

packages/opentelemetry-tracing/src/BasicTracerFactory.ts

@@ -14,36 +14,19 @@
  * limitations under the License.
  */
 
-import * as types from '@opentelemetry/types';
 import { BasicTracerConfig } from './types';
 import { BasicTracer } from './BasicTracer';
-import { SpanProcessor } from './SpanProcessor';
+import { AbstractBasicTracerFactory } from './AbstractBasicTracerFactory';
 
-export class BasicTracerFactory implements types.TracerFactory {
-  private readonly _tracers: Map<string, BasicTracer> = new Map();
-  private _spanProcessors: SpanProcessor[] = [];
+export class BasicTracerFactory extends AbstractBasicTracerFactory {
   private _config?: BasicTracerConfig;
 
   constructor(config?: BasicTracerConfig) {
+    super();
     this._config = config;
   }
 
-  addSpanProcessor(spanProcessor: SpanProcessor): void {
-    this._spanProcessors.push(spanProcessor);
-    for (const tracer of this._tracers.values()) {
-      tracer.addSpanProcessor(spanProcessor);
-    }
-  }
-
-  getTracer(name: string = '', version?: string): types.Tracer {
-    const key = name + (version != undefined ? version : '');
-    if (this._tracers.has(key)) return this._tracers.get(key)!;
-
-    const tracer = new BasicTracer(this._config);
-    for (const processor of this._spanProcessors) {
-      tracer.addSpanProcessor(processor);
-    }
-    this._tracers.set(key, tracer);
-    return tracer;
+  _newTracer(): BasicTracer {
+    return new BasicTracer(this._config);
   }
 }

packages/opentelemetry-tracing/src/index.ts

@@ -25,3 +25,4 @@ export * from './export/SpanExporter';
 export * from './Span';
 export * from './SpanProcessor';
 export * from './types';
+export * from './AbstractBasicTracerFactory';

packages/opentelemetry-web/src/WebTracerFactory.ts

@@ -0,0 +1,35 @@
+/*!
+ * Copyright 2019, OpenTelemetry Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { WebTracer } from './WebTracer';
+import {
+  BasicTracer,
+  AbstractBasicTracerFactory,
+  BasicTracerConfig,
+} from '@opentelemetry/tracing';
+
+export class WebTracerFactory extends AbstractBasicTracerFactory {
+  private readonly _config?: BasicTracerConfig;
+
+  constructor(config?: BasicTracerConfig) {
+    super();
+    this._config = config;
+  }
+
+  protected _newTracer(): BasicTracer {
+    return new WebTracer(this._config);
+  }
+}