Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add isEnabled to InstrumentationBase #2135

Merged
merged 3 commits into from
Apr 21, 2021
+4 −0
Merged

fix: add isEnabled to InstrumentationBase #2135

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f078ae5
fix: change _enabled to protected at instrumentationbase
seemk Apr 21, 2021
5d84125
refactor: use isEnabled
seemk Apr 21, 2021
b031c3b
Merge branch 'main' into instr-protected-enable
dyladan Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export abstract class InstrumentationBase<T = any>
implements types.Instrumentation {
private _modules: InstrumentationModuleDefinition<T>[];
private _hooks: RequireInTheMiddle.Hooked[] = [];
private _enabled = false;
protected _enabled = false;
dyladan marked this conversation as resolved.
Show resolved Hide resolved

constructor(
instrumentationName: string,
Expand Down