feat(node-tracer): use AsyncLocalStorageContextManager by default sta…

…rting Node 14.8
open-telemetry · Sep 13, 2020 · dd701fc · dd701fc
1 parent f824195
commit dd701fc
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/packages/opentelemetry-node/src/NodeTracerProvider.ts b/packages/opentelemetry-node/src/NodeTracerProvider.ts
@@ -14,13 +14,17 @@
  * limitations under the License.
  */
 
-import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
+import {
+  AsyncHooksContextManager,
+  AsyncLocalStorageContextManager,
+} from '@opentelemetry/context-async-hooks';
 import {
   BasicTracerProvider,
   SDKRegistrationConfig,
 } from '@opentelemetry/tracing';
 import { DEFAULT_INSTRUMENTATION_PLUGINS, NodeTracerConfig } from './config';
 import { PluginLoader, Plugins } from './instrumentation/PluginLoader';
+import * as semver from 'semver';
 
 /**
  * Register this TracerProvider for use with the OpenTelemetry API.
@@ -53,7 +57,10 @@ export class NodeTracerProvider extends BasicTracerProvider {
 
   register(config: SDKRegistrationConfig = {}) {
     if (config.contextManager === undefined) {
-      config.contextManager = new AsyncHooksContextManager();
+      const ContextManager = semver.gte(process.version, '14.8.0')
+        ? AsyncLocalStorageContextManager
+        : AsyncHooksContextManager;
+      config.contextManager = new ContextManager();
       config.contextManager.enable();
     }
 

diff --git a/packages/opentelemetry-node/test/registration.test.ts b/packages/opentelemetry-node/test/registration.test.ts
@@ -21,11 +21,19 @@ import {
   trace,
   ProxyTracerProvider,
 } from '@opentelemetry/api';
-import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
+import {
+  AsyncHooksContextManager,
+  AsyncLocalStorageContextManager,
+} from '@opentelemetry/context-async-hooks';
 import { NoopContextManager } from '@opentelemetry/context-base';
 import { CompositePropagator } from '@opentelemetry/core';
 import * as assert from 'assert';
 import { NodeTracerProvider } from '../src';
+import * as semver from 'semver';
+
+const DdefaultContextManager = semver.gte(process.version, '14.8.0')
+  ? AsyncLocalStorageContextManager
+  : AsyncHooksContextManager;
 
 describe('API registration', () => {
   beforeEach(() => {
@@ -39,7 +47,7 @@ describe('API registration', () => {
     tracerProvider.register();
 
     assert.ok(
-      context['_getContextManager']() instanceof AsyncHooksContextManager
+      context['_getContextManager']() instanceof DdefaultContextManager
     );
     assert.ok(
       propagation['_getGlobalPropagator']() instanceof CompositePropagator
@@ -97,7 +105,7 @@ describe('API registration', () => {
     );
 
     assert.ok(
-      context['_getContextManager']() instanceof AsyncHooksContextManager
+      context['_getContextManager']() instanceof DdefaultContextManager
     );
 
     const apiTracerProvider = trace.getTracerProvider();