test(instrumentation-http): remove tests for deprecated request packa…

…ge (#5328)
open-telemetry · Jan 13, 2025 · 6f18ec2 · 6f18ec2
1 parent cb88833
commit 6f18ec2
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 752 deletions.
diff --git a/experimental/packages/opentelemetry-instrumentation-http/package.json b/experimental/packages/opentelemetry-instrumentation-http/package.json
@@ -64,8 +64,6 @@
     "mocha": "10.8.2",
     "nock": "13.5.6",
     "nyc": "17.1.0",
-    "request": "2.88.2",
-    "request-promise-native": "1.0.9",
     "sinon": "15.1.2",
     "superagent": "10.1.1",
     "typescript": "5.0.4"

diff --git a/...imental/packages/opentelemetry-instrumentation-http/test/functionals/http-package.test.ts b/...imental/packages/opentelemetry-instrumentation-http/test/functionals/http-package.test.ts
@@ -33,10 +33,7 @@ instrumentation.enable();
 instrumentation.disable();
 
 import * as http from 'http';
-import * as request from 'request-promise-native';
 import * as superagent from 'superagent';
-// Temporarily removed. See /~https://github.com/open-telemetry/opentelemetry-js/issues/3344
-// import * as got from 'got';
 import * as nock from 'nock';
 import * as axios from 'axios';
 
@@ -82,11 +79,6 @@ describe('Packages', () => {
     [
       { name: 'axios', httpPackage: axios }, //keep first
       { name: 'superagent', httpPackage: superagent },
-      // { name: 'got', httpPackage: { get: (url: string) => got(url) } },
-      {
-        name: 'request',
-        httpPackage: { get: (url: string) => request(url) },
-      },
     ].forEach(({ name, httpPackage }) => {
       it(`should create a span for GET requests and add propagation headers by using ${name} package`, async () => {
         nock.load(path.join(__dirname, '../', '/fixtures/google-http.json'));
@@ -123,7 +115,6 @@ describe('Packages', () => {
               result.request._headers[DummyPropagation.SPAN_CONTEXT_KEY]
             );
             break;
-          case 'got':
           case 'superagent':
             break;
           default:

diff --git a/...mental/packages/opentelemetry-instrumentation-http/test/functionals/https-package.test.ts b/...mental/packages/opentelemetry-instrumentation-http/test/functionals/https-package.test.ts
@@ -33,10 +33,7 @@ instrumentation.enable();
 instrumentation.disable();
 
 import * as http from 'http';
-import * as request from 'request-promise-native';
 import * as superagent from 'superagent';
-// Temporarily removed. See /~https://github.com/open-telemetry/opentelemetry-js/issues/3344
-// import * as got from 'got';
 import * as nock from 'nock';
 import * as axios from 'axios';
 
@@ -82,11 +79,6 @@ describe('Packages', () => {
     [
       { name: 'axios', httpPackage: axios }, //keep first
       { name: 'superagent', httpPackage: superagent },
-      // { name: 'got', httpPackage: { get: (url: string) => got(url) } },
-      {
-        name: 'request',
-        httpPackage: { get: (url: string) => request(url) },
-      },
     ].forEach(({ name, httpPackage }) => {
       it(`should create a span for GET requests and add propagation headers by using ${name} package`, async () => {
         nock.load(path.join(__dirname, '../', '/fixtures/google-https.json'));
@@ -123,7 +115,6 @@ describe('Packages', () => {
               result.request._headers[DummyPropagation.SPAN_CONTEXT_KEY]
             );
             break;
-          case 'got':
           case 'superagent':
             break;
           default: