Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(restify): Skip update HTTP's span name and update RpcMetadata's route instead #1571

Merged
merged 7 commits into from
Aug 12, 2023

Conversation

chigia001
Copy link
Contributor

@chigia001 chigia001 commented Jul 12, 2023

Which problem is this PR solving?

Each framework has a different approach to updating Span's name and HTTP_ROUTE attribute. We want to delegate this to instrumentation-http for consistent's name and attribute
This PR fixes the above issue for restify@8.6.1

Short description of the changes

  • Skip modifying HTTP's Span name directly in instrumentation-restify code
  • Update route property of RpcMetadata

Next step

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1571 (0e486df) into main (10bdbf7) will decrease coverage by 4.27%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
- Coverage   96.06%   91.79%   -4.27%     
==========================================
  Files          14      139     +125     
  Lines         914     7117    +6203     
  Branches      199     1431    +1232     
==========================================
+ Hits          878     6533    +5655     
- Misses         36      584     +548     
Files Changed Coverage Δ
...try-instrumentation-restify/src/instrumentation.ts 90.35% <100.00%> (ø)

... and 124 files with indirect coverage changes

@blumamir blumamir merged commit 7d4b13e into open-telemetry:main Aug 12, 2023
@dyladan dyladan mentioned this pull request Aug 12, 2023
@chigia001 chigia001 deleted the fix-1381-restify branch August 13, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants