Now publish all instrumentations as well. #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed groupId to `io.opentelemetry.instrumentation`. Removed `opentelemetry` from auto-exporters' artifactIds. Some instrumentations will need moving around to have better names, e.g. servlets. Should I do it right away?
|
How about
Possible motivation for keeping it: open-telemetry/opentelemetry-specification#629
I would be happy with that |
but also no problem if you prefer to separate |
|
what about prefixing artifactIds? that is pretty common convention, e.g.
and (for manual instrumentation)
|
Should we put agent and auto-exporters under
Yeah :( Will put them back. What do you think about renaming actual agent artifactId to |
I don't know about that... |
i can't come up with a preference between
i cannot disagree 😭 |
|
Regarding individual instrumentations: I think the 99.(9)% users of them will be vendor repackaging their own distribution. They don't actually care about artefact name because it will be destroyed anyway. So But for users of manual instrumentation |
|
|
Closes #163 now as well |
trask
reviewed
Jun 26, 2020
| include ':instrumentation:ratpack-1.5' | ||
| include ':instrumentation:reactor-3.1' | ||
| include ':instrumentation:project-reactor-3.1' | ||
| include ':instrumentation:rediscala-1.8' | ||
| include ':instrumentation:rmi' | ||
| include ':instrumentation:rxjava-1.0' | ||
| include ':instrumentation:servlet' |
There was a problem hiding this comment.
I opened #586 to track what to do with the :instrumentation:servlet module
settings.gradle
Outdated
| include ':instrumentation:ratpack-1.5' | ||
| include ':instrumentation:reactor-3.1' | ||
| include ':instrumentation:project-reactor-3.1' |
There was a problem hiding this comment.
sorry, i was later convinced that reactor alone was sufficient, but didn't update that issue
|
Are these published anywhere not seeing anything on https://bintray.com/open-telemetry |
|
hey @imduffy15! you can find snapshots here: https://oss.jfrog.org/artifactory/oss-snapshot-local/io/opentelemetry |
|
@trask I cannot find the auto-tooling and auto-bootstrap artifacts that are specified in most poms. |
|
That is a great question... For some reason we don't publish those. @BladeWise thank you for spotting this! We will fix it ASAP, hopefully today. |
|
@BladeWise new snapshots are published: https://oss.jfrog.org/artifactory/oss-snapshot-local/io/opentelemetry/instrumentation/auto/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135
Changed groupId to
io.opentelemetry.instrumentation.Removed
opentelemetryfrom auto-exporters' artifactIds.Some instrumentations will need moving around to have better names, e.g. servlets. Should I do it right away?