return assert.AnError from mockHostIDProviderWithError

open-telemetry · Mar 8, 2023 · f850251 · f850251
1 parent 8f6b557
commit f850251
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/sdk/resource/host_id_export_test.go b/sdk/resource/host_id_export_test.go
@@ -15,8 +15,7 @@
 package resource_test
 
 import (
-	"errors"
-
+	"github.com/stretchr/testify/assert"
 	"go.opentelemetry.io/otel/sdk/resource"
 )
 
@@ -28,8 +27,7 @@ func mockHostIDProvider() {
 
 func mockHostIDProviderWithError() {
 	resource.SetHostIDProvider(
-		// TODO: After #3844 merges, return assert.AnError and update tests in `resource_test.go`.
-		func() (string, error) { return "", errors.New("not found") },
+		func() (string, error) { return "", assert.AnError },
 	)
 }
 

diff --git a/sdk/resource/resource_test.go b/sdk/resource/resource_test.go
@@ -498,6 +498,7 @@ func TestWithHostIDError(t *testing.T) {
 	)
 
 	require.Error(t, err)
+	assert.True(t, errors.Is(err, assert.AnError))
 	require.EqualValues(t, map[string]string{}, toMap(res))
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -498,6 +498,7 @@ func TestWithHostIDError(t *testing.T) { @@
     	)
     	require.Error(t, err)
+    	assert.True(t, errors.Is(err, assert.AnError))
     	require.EqualValues(t, map[string]string{}, toMap(res))
     }
@@ Expand Down @@