Skip to content

Commit

Permalink
Merge branch 'main' into feature/add_new_function_to_exclude_4xx_stat…
Browse files Browse the repository at this point in the history
…us_code
  • Loading branch information
hanyuancheung authored Nov 11, 2021
2 parents 070d4cc + d0e5dd5 commit 868d06b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ examples:
$(GO) build .); \
done

generate: $(STRINGER)
generate: $(STRINGER) $(PORTO)
set -e; for dir in $(ALL_GO_MOD_DIRS); do \
echo "$(GO) generate $${dir}/..."; \
(cd "$${dir}" && \
Expand Down
6 changes: 3 additions & 3 deletions website_docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import (
"log"
)

// App is an Fibonacci computation application.
// App is a Fibonacci computation application.
type App struct {
r io.Reader
l *log.Logger
Expand Down Expand Up @@ -176,7 +176,7 @@ To back up a bit, a trace is a type of telemetry that represents work being done

Each part of the work that a service performs is represented in the trace by a span. Those spans are not just an unordered collection. Like the call stack of our application, those spans are defined with relationships to one another. The "root" span is the only span without a parent, it represents how a service request is started. All other spans have a parent relationship to another span in the same trace.

If this last part about span relationships doesn't make complete sense now, don't worry. The important thing to take away is each part of your code that does work should to be represented as a span. You will have a better understanding of these span relationships after you instrument your code, so let's get started.
If this last part about span relationships doesn't make complete sense now, don't worry. The most important takeaway is that each part of your code, which does some work, should be represented as a span. You will have a better understanding of these span relationships after you instrument your code, so let's get started.

Start by instrumenting the `Run` method.

Expand Down Expand Up @@ -296,7 +296,7 @@ To initialize the console exporter, add the following function to the `main.go`
func newExporter(w io.Writer) (trace.SpanExporter, error) {
return stdouttrace.New(
stdouttrace.WithWriter(w),
// Use human readable output.
// Use human-readable output.
stdouttrace.WithPrettyPrint(),
// Do not print timestamps for the demo.
stdouttrace.WithoutTimestamps(),
Expand Down

0 comments on commit 868d06b

Please sign in to comment.