Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
  • Loading branch information
mwear and MrAlias committed Mar 1, 2023
1 parent b64c55c commit 0358f54
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sdk/resource/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func WithHost() Option {
return WithDetectors(host{})
}

// WithHostID adds a host id attribute to the configured resource
// WithHostID adds host ID information to the configured resource.
func WithHostID() Option {
return WithDetectors(hostIDDetector{})
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/resource/host_id_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type hostIDReaderLinux struct {
}

// read attempts to read the machine-id from /etc/machine-id followed by
// /var/lib/dbus/machine-id. If neither location yields an id an error will
// /var/lib/dbus/machine-id. If neither location yields an ID an error will
// be returned.
func (r *hostIDReaderLinux) read() (string, error) {
if result, err := r.readFile("/etc/machine-id"); err == nil {
Expand Down
2 changes: 1 addition & 1 deletion sdk/resource/host_id_unsupported.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

package resource // import "go.opentelemetry.io/otel/sdk/resource"

// hostIDReaderUnsupported is a placeholder implementation for OSes
// hostIDReaderUnsupported is a placeholder implementation for operating systems
// for which this project currently doesn't support host.id
// attribute detection. See build tags declaration early on this file
// for a list of unsupported OSes.
Expand Down

0 comments on commit 0358f54

Please sign in to comment.