-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] Improve errors for invalid cache access and add option to set context's cache value #37166
Merged
TylerHelmuth
merged 6 commits into
open-telemetry:main
from
edmocosta:ottl-cache-changes
Jan 13, 2025
Merged
[pkg/ottl] Improve errors for invalid cache access and add option to set context's cache value #37166
TylerHelmuth
merged 6 commits into
open-telemetry:main
from
edmocosta:ottl-cache-changes
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to set their values
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
January 13, 2025 13:13
evan-bradley
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@edmocosta needs |
…lector-contrib into ottl-cache-changes
This reverts commit 862ae51.
@edmocosta sorry we reverted the tidylist as it was causing problems. Now we need a rebase |
…lector-contrib into ottl-cache-changes
NP, CI is green now, thanks for handling it. |
TylerHelmuth
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved error message for higher context
cache
access. Now when users try to configure statements likeset(log.attributes["log_key"], resource.cache["log_key"])
, they will see an error message similar to:Added the
WithCache
option to all OTTL transformation contexts. This change allows API consumer to set the initial cache value or share it among different contexts/executions.Link to tracking issue
Split of #36888
Testing
Unit tests