Updated Sampling Result names #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. |
JamesJHPark
pushed a commit
that referenced
this pull request
Oct 26, 2021
open-telemetry#3770) * Replaced hardcoded localhost with OS resolved localhost name in tests. * Replaced hardcoded localhost with OS resolved localhost name in tests. #2 * retrigger checks #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the names of Sampling result for consistency, closing #1648
The changes have been made following these specifications:
open-telemetry/opentelemetry-specification#938
open-telemetry/opentelemetry-specification#956
Changed from:
NOT_RECORDRECORDRECORD_AND_SAMPLEDChanged to:
DROPRECORD_ONLYRECORD_AND_SAMPLE