Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout param for DocSum and FaqGen to deal with long context #1329

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

XinyaoWa
Copy link
Collaborator

Description

Make timeout param configurable, more flexible when deal with longer context.

Issues

opea-project/GenAIExamples#1481

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

no

Tests

Describe the tests that you ran to verify your changes.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
comps/cores/proto/api_protocol.py 96.14% <100.00%> (+<0.01%) ⬆️

Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, timeout parameter is added for doc summation + FAQ generation, and documented & used in tests for former.

@eero-t
Copy link
Contributor

eero-t commented Feb 25, 2025

4 CI tests fail, but it seems unralated to changes here...

/llms/test_llms_faq-generation_vllm_on_intel_hpu.sh: line 1: #!/bin/bash: No such file or directory

Error response from daemon: Conflict. The container name "/tgi-gaudi-server" is already in use by container "161f5fc92b25b8c9255cabefa85160e79246918ac64c3245a209445608d8df55". You have to remove (or rename) that container to be able to reuse that name.

Make timeout param configurable, solve issue opea-project/GenAIExamples#1481

Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants