Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats about account format versions to util's checkpoint-collect-stats command #6882

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fxamacker
Copy link
Member

@fxamacker fxamacker commented Jan 14, 2025

Updates onflow/cadence#3584
Closes #6610

This PR updates util program's checkpoint-collect-stats command to output stats about account format versions (e.g. counts for v1 vs v2).

While at it, also bump montanaflynn/stats package to the latest version.

@fxamacker fxamacker requested a review from a team January 14, 2025 00:47
@fxamacker fxamacker requested a review from a team as a code owner January 14, 2025 00:47
@fxamacker fxamacker self-assigned this Jan 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 122 lines in your changes missing coverage. Please review.

Project coverage is 41.11%. Comparing base (b740fc0) to head (f28c711).

Files with missing lines Patch % Lines
...util/cmd/checkpoint-collect-stats/account_stats.go 0.00% 52 Missing ⚠️
cmd/util/cmd/checkpoint-collect-stats/cmd.go 0.00% 41 Missing ⚠️
...d/util/cmd/checkpoint-collect-stats/stats_utils.go 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6882      +/-   ##
==========================================
- Coverage   41.11%   41.11%   -0.01%     
==========================================
  Files        2116     2118       +2     
  Lines      185749   185785      +36     
==========================================
+ Hits        76378    76387       +9     
- Misses     102954   102983      +29     
+ Partials     6417     6415       -2     
Flag Coverage Δ
unittests 41.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update checkpoint-collect-stats cmd to collect stats on new account registers
2 participants