Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceMSAN] Fix MemToShadow algorithm and VA reservation #2507

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Dec 25, 2024

@AllanZyne AllanZyne requested a review from a team as a code owner December 25, 2024 06:04
@github-actions github-actions bot added the loader Loader related feature/bug label Dec 25, 2024
@AllanZyne AllanZyne changed the title [DeviceMSAN] Fix MSAN MemToShadow algorithm and VA reservation [DeviceMSAN] Fix MemToShadow algorithm and VA reservation Dec 25, 2024
Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllanZyne
Copy link
Contributor Author

@oneapi-src/unified-runtime-maintain, please add to 2025.1

@aarongreig aarongreig added the v0.11.x Include in the v0.11.x release label Dec 26, 2024
@AllanZyne
Copy link
Contributor Author

AllanZyne commented Dec 26, 2024

A note for myself: remove debug key in msan_ddi

@AllanZyne
Copy link
Contributor Author

A note for myself: remove debug key in msan_ddi

After tested on latest gfx driver, I found I still need to use these keys, I will sync with L0 team.

@AllanZyne
Copy link
Contributor Author

Hi @oneapi-src/unified-runtime-maintain, this is an important bugfix, please review.
Thanks!

@aarongreig aarongreig merged commit fe6c83a into oneapi-src:main Dec 27, 2024
73 checks passed
@AllanZyne AllanZyne deleted the review/yang/fix_msan_shadow branch December 30, 2024 04:18
kbenzie pushed a commit that referenced this pull request Jan 8, 2025
[DeviceMSAN] Fix MemToShadow algorithm and VA reservation
kbenzie pushed a commit that referenced this pull request Jan 8, 2025
[DeviceMSAN] Fix MemToShadow algorithm and VA reservation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loader Loader related feature/bug v0.11.x Include in the v0.11.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants