chore: ensure imports are sorted #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
sorted
branch
2 times, most recently
from
2549afb to
b51a8cd
Compare
|
@ParthSareen Rebased. Can you take a peek? |
ParthSareen
reviewed
Jan 14, 2025
|
Hey @akx, the I'm down for ruff sorting though - but please try to keep the diff small |
My reasoning here was that it's easier to see where these imports are coming from. But I can rip that commit out of this PR, nbd. (That's why I do atomic commits.) |
akx
changed the title
|
Appreciate it! @akx |
ParthSareen
approved these changes
Jan 15, 2025
|
Thanks for this! @akx |
pressdarling
pushed a commit
to pressdarling/ollama-python
that referenced
this pull request
Feb 1, 2025
* chore: upgrade ruff & sort imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Ruff (closes #415) and enables Ruff import sorting.