Fix blobs request #350
Closed
Fix blobs request #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Steiner
force-pushed
the
fix-blob-request
branch
from
0d98697 to
df2ae3e
Compare
Robert-Steiner
force-pushed
the
fix-blob-request
branch
from
df2ae3e to
b796e33
Compare
|
Hey @Robert-Steiner! Thanks for this! Could you also add a test to ensure this behavior is good? Thanks :) |
|
Hey @ParthSareen, |
Robert-Steiner
force-pushed
the
fix-blob-request
branch
from
cfd9bde to
a9a6b4e
Compare
|
Hey @Robert-Steiner could you fix the conflicts? Rest looks good! Will get this in when fixed. Sorry for the delay! |
Signed-off-by: Robert Steiner <robert@flower.ai>
Robert-Steiner
force-pushed
the
fix-blob-request
branch
from
a9a6b4e to
75792c5
Compare
|
Hey @ParthSareen I resolved the merge conflict :) |
|
I don't know if something is wrong on my end but I don't think I see your changes anymore? LOL @Robert-Steiner |
|
@ParthSareen you are right! It was fixed in #420 |
|
Oops I think we could've still gotten the tests in haha - I'll get it in! Appreciate the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blobs request fails with
invalid digest formatbecausesha256:is added twice in lines 557 and 560.This PR removes the extra
sha256:in line 560.