Skip to content
This repository has been archived by the owner on Feb 8, 2025. It is now read-only.

fix: fix search function to accept null criteria as empty query string #1138

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Jun 26, 2021

Fix #1137

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin requested a review from djaiss June 26, 2021 13:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
29.8% 29.8% Duplication

Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very good changes, but there are two-three changes I don't understand.

@asbiin asbiin merged commit bae676b into main Jun 30, 2021
@asbiin asbiin deleted the 20210626-fix-search branch June 30, 2021 21:02
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants