Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): replace @gr2m/fetch-mock with fetch-mock #2697

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

wolfy1339
Copy link
Member

Resolves #2696


Before the change?

  • Used a custom fork of fetch-mock for Fetch API support

After the change?

  • Use the fetch-mock module again, it has been updated to support the Fetch API

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 15, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@gr2m
Copy link
Contributor

gr2m commented Jun 15, 2024

Oh I think there is a special module for using fetch mock with jest. Sorry I'm on my phone today

@wolfy1339

This comment was marked as resolved.

@wolfy1339 wolfy1339 marked this pull request as ready for review June 17, 2024 00:38
@gr2m gr2m merged commit cd0e1ed into main Jun 18, 2024
6 checks passed
@gr2m gr2m deleted the fetch-mock-v10 branch June 18, 2024 05:03
Copy link

🎉 This PR is included in version 4.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

update to latest fetch-mock
2 participants