-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Raphael V2.2.7 to V2.2.8 #4263
Conversation
Update Raphael V2.2.7 to V2.2.8 shouldn't be a problem to update to October as as minor semantic version update. Side note: The V2.2.7 was dated two years ago and V2.2.8 this year, as many features have been updated to the internet this new version brings some useful features and upgrades to October CMS.
@w20k If you got any free time, would you like to test this ? Thanks in advance! |
@ayumihamsaki the difference between the two versions in terms of the actual code is quite dramatic, it looks like it's now some sort of compiled webpack crap? Is there an option without that mess? |
@LukeTowers Yah I hate Webpack as well makes javascript files way too big in size! I had a look for a none-webpack version and they are all webpack versions now. The only choices on V2.2.8 are:
*All four versions are bundled webpack. I took the following version (because we use
Not sure what to do - to get you a non-webpack version though. |
Side note: they were using webpack V4 to compile this version. |
What exactly do we gain by upgrading? |
V2.2.8
This is my guess. |
Hmm. What do you think about manually porting only the relevant fixes over? |
I'm thinking this version and all the future versions they plan to use webpack now. Looking at the code file it is pure garage to bug fix for october. The question comes to mind do we need to bug fix this file or will the errors be in the october files instead? I don't mind leaving this PR open and not adding it to October, this package related to things like the scoreboard see here: https://octobercms.com/docs/ui/scoreboard Right now I don't see any major errors or issues with it and I have lots of custom plugins using these things everyday! If there was a big issue I would have filed it. So personally I think just leave this pr open and decide at a later date. The jQuery V3.4.0 that is quite important as it has a major security fix and quite a few updates to some things needed for october. I will add that list to that pr now for ref. |
I'll close this PR for now, we can look at making any fixes if they ever come up as issues here. |
Update Raphael V2.2.7 to V2.2.8 shouldn't be a problem to update to October as as minor semantic version update.
Side note: The V2.2.7 was dated two years ago and V2.2.8 this year, as many features have been updated to the internet this new version brings some useful features and upgrades to October CMS.
ref: #3867