Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Raphael V2.2.7 to V2.2.8 #4263

Closed
wants to merge 1 commit into from
Closed

Update Raphael V2.2.7 to V2.2.8 #4263

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 16, 2019

Update Raphael V2.2.7 to V2.2.8 shouldn't be a problem to update to October as as minor semantic version update.

Side note: The V2.2.7 was dated two years ago and V2.2.8 this year, as many features have been updated to the internet this new version brings some useful features and upgrades to October CMS.

ref: #3867

Update Raphael V2.2.7 to V2.2.8 shouldn't be a problem to update to October as as minor semantic version update.

Side note: The V2.2.7 was dated two years ago and V2.2.8 this year, as many features have been updated to the internet this new version brings some useful features and upgrades to October CMS.
@ghost
Copy link
Author

ghost commented Apr 16, 2019

@ghost
Copy link
Author

ghost commented Apr 16, 2019

@w20k If you got any free time, would you like to test this ? Thanks in advance!

@LukeTowers
Copy link
Contributor

@ayumihamsaki the difference between the two versions in terms of the actual code is quite dramatic, it looks like it's now some sort of compiled webpack crap? Is there an option without that mess?

@ghost
Copy link
Author

ghost commented Apr 17, 2019

@LukeTowers Yah I hate Webpack as well makes javascript files way too big in size! I had a look for a none-webpack version and they are all webpack versions now.

The only choices on V2.2.8 are:

  • raphael.min.js (includes eve and it's minified)
  • raphael.js (includes eve and it's not minified)
  • raphael.no-deps.js (doesn't include eve it's not minified)
  • raphael.no-deps.min.js (doesn't include eve it's minified)

*All four versions are bundled webpack.

I took the following version (because we use Eve):

  • raphael.js (includes eve and it's not minified)

Not sure what to do - to get you a non-webpack version though.

@ghost
Copy link
Author

ghost commented Apr 17, 2019

Side note: they were using webpack V4 to compile this version.

@LukeTowers
Copy link
Contributor

What exactly do we gain by upgrading?

@ghost
Copy link
Author

ghost commented Apr 18, 2019

V2.2.8

  • Downgraded qunit to v1 to make tests work again
  • Updated webpack to build dist
  • Updated supportsTouch query from modernizr #1084 (possible improvement to october with touchscreens)
  • Fix drag offsets passed to "drag.start" from touch drags in elproto.drag #1101 (possible improvement to october with touchscreens)
  • Fix memory leak in Element.removeData() #1077 (possible bug fix for october cms)
  • Adding react-raphael to related projects #1072
  • Added icons back to raphael's website
  • Updated version in banner and raphael's website
  • Updated site refs to https

This is my guess.

@LukeTowers
Copy link
Contributor

Hmm. What do you think about manually porting only the relevant fixes over?

@ghost
Copy link
Author

ghost commented Apr 18, 2019

I'm thinking this version and all the future versions they plan to use webpack now. Looking at the code file it is pure garage to bug fix for october. The question comes to mind do we need to bug fix this file or will the errors be in the october files instead?

I don't mind leaving this PR open and not adding it to October, this package related to things like the scoreboard see here: https://octobercms.com/docs/ui/scoreboard

Right now I don't see any major errors or issues with it and I have lots of custom plugins using these things everyday! If there was a big issue I would have filed it.

So personally I think just leave this pr open and decide at a later date. The jQuery V3.4.0 that is quite important as it has a major security fix and quite a few updates to some things needed for october. I will add that list to that pr now for ref.

@LukeTowers
Copy link
Contributor

I'll close this PR for now, we can look at making any fixes if they ever come up as issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant