Use @tsconfig/strictest instead

Signed-off-by: Sora Morimoto <sora@morimoto.io>
ocaml · Sep 24, 2022 · 57f9b5a · 57f9b5a
1 parent d011f62
commit 57f9b5a
Show file tree

Hide file tree

Showing 14 changed files with 95 additions and 67 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/post/index.js b/dist/post/index.js
diff --git a/lint-doc/index.js b/lint-doc/index.js
diff --git a/lint-fmt/index.js b/lint-fmt/index.js
diff --git a/package.json b/package.json
@@ -29,6 +29,7 @@
     "yaml": "2.1.1"
   },
   "devDependencies": {
+    "@tsconfig/strictest": "1.0.1",
     "@types/node": "18.7.18",
     "@types/semver": "7.3.12",
     "@typescript-eslint/eslint-plugin": "5.38.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/lint-doc/odoc.ts b/src/lint-doc/odoc.ts
@@ -5,7 +5,7 @@ export async function lintOdoc() {
   const options: ExecOptions = {
     env: {
       ...process.env,
-      PATH: process.env.PATH ?? "",
+      PATH: process.env["PATH"] ?? "",
       ODOC_WARN_ERROR: "true",
     },
   };

diff --git a/src/lint-fmt/ocamlformat.ts b/src/lint-fmt/ocamlformat.ts
@@ -5,7 +5,7 @@ import * as path from "path";
 import { convertToUnix } from "./compat";
 
 async function parse() {
-  const githubWorkspace = process.env.GITHUB_WORKSPACE ?? process.cwd();
+  const githubWorkspace = process.env["GITHUB_WORKSPACE"] ?? process.cwd();
   const fpath = path.join(githubWorkspace, ".ocamlformat");
   const buf = await fs.readFile(fpath);
   const str = buf.toString();

diff --git a/src/setup-ocaml/cache.ts b/src/setup-ocaml/cache.ts
@@ -111,7 +111,7 @@ function composeOpamDownloadCacheKeys() {
 
 function composeCygwinCachePaths() {
   const paths = [];
-  const githubWorkspace = process.env.GITHUB_WORKSPACE ?? process.cwd();
+  const githubWorkspace = process.env["GITHUB_WORKSPACE"] ?? process.cwd();
   const cygwinRoot = path.join("D:", "cygwin");
   paths.push(cygwinRoot);
   const cygwinRootSymlinkPath = path.posix.join("/cygdrive", "d", "cygwin");
@@ -132,7 +132,7 @@ function composeDuneCachePaths() {
     const duneCacheDir = path.join(homeDir, "Local Settings", "Cache", "dune");
     paths.push(duneCacheDir);
   } else {
-    const xdgCacheHome = process.env.XDG_CACHE_HOME;
+    const xdgCacheHome = process.env["XDG_CACHE_HOME"];
     const duneCacheDir = xdgCacheHome
       ? path.join(xdgCacheHome, "dune")
       : path.join(homeDir, ".cache", "dune");
@@ -164,7 +164,7 @@ function composeOpamCachePaths() {
     const opamRootCachePath = path.join(homeDir, ".opam");
     paths.push(opamRootCachePath);
   }
-  const githubWorkspace = process.env.GITHUB_WORKSPACE ?? process.cwd();
+  const githubWorkspace = process.env["GITHUB_WORKSPACE"] ?? process.cwd();
   const opamLocalCachePath = path.join(githubWorkspace, "_opam");
   paths.push(opamLocalCachePath);
   return paths;

diff --git a/src/setup-ocaml/installer.ts b/src/setup-ocaml/installer.ts
@@ -66,27 +66,27 @@ export async function installer(): Promise<void> {
     core.endGroup();
   }
   if (platform === Platform.Win32) {
-    core.exportVariable("HOME", process.env.USERPROFILE);
+    core.exportVariable("HOME", process.env["USERPROFILE"]);
     core.exportVariable("MSYS", "winsymlinks:native");
   }
   if (platform === Platform.Win32) {
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    const originalPath = process.env.PATH!.split(path.delimiter);
+    const originalPath = process.env["PATH"]!.split(path.delimiter);
     const msys64Path = path.join("C:", "msys64", "usr", "bin");
     const patchedPath = [msys64Path, ...originalPath];
-    process.env.PATH = patchedPath.join(path.delimiter);
+    process.env["PATH"] = patchedPath.join(path.delimiter);
     await restoreCygwinCache();
-    process.env.PATH = originalPath.join(path.delimiter);
+    process.env["PATH"] = originalPath.join(path.delimiter);
   }
   let opamCacheHit;
   if (platform === Platform.Win32) {
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    const originalPath = process.env.PATH!.split(path.delimiter);
+    const originalPath = process.env["PATH"]!.split(path.delimiter);
     const msys64Path = path.join("C:", "msys64", "usr", "bin");
     const patchedPath = [msys64Path, ...originalPath];
-    process.env.PATH = patchedPath.join(path.delimiter);
+    process.env["PATH"] = patchedPath.join(path.delimiter);
     opamCacheHit = await restoreOpamCache();
-    process.env.PATH = originalPath.join(path.delimiter);
+    process.env["PATH"] = originalPath.join(path.delimiter);
   } else {
     opamCacheHit = await restoreOpamCache();
   }
@@ -102,24 +102,24 @@ export async function installer(): Promise<void> {
     await installOcaml(ocamlCompiler);
     if (platform === Platform.Win32) {
       // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-      const originalPath = process.env.PATH!.split(path.delimiter);
+      const originalPath = process.env["PATH"]!.split(path.delimiter);
       const msys64Path = path.join("C:", "msys64", "usr", "bin");
       const patchedPath = [msys64Path, ...originalPath];
-      process.env.PATH = patchedPath.join(path.delimiter);
+      process.env["PATH"] = patchedPath.join(path.delimiter);
       await saveOpamCache();
-      process.env.PATH = originalPath.join(path.delimiter);
+      process.env["PATH"] = originalPath.join(path.delimiter);
     } else {
       await saveOpamCache();
     }
   }
   if (platform === Platform.Win32) {
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    const originalPath = process.env.PATH!.split(path.delimiter);
+    const originalPath = process.env["PATH"]!.split(path.delimiter);
     const msys64Path = path.join("C:", "msys64", "usr", "bin");
     const patchedPath = [msys64Path, ...originalPath];
-    process.env.PATH = patchedPath.join(path.delimiter);
+    process.env["PATH"] = patchedPath.join(path.delimiter);
     await restoreOpamDownloadCache();
-    process.env.PATH = originalPath.join(path.delimiter);
+    process.env["PATH"] = originalPath.join(path.delimiter);
   } else {
     await restoreOpamDownloadCache();
   }
@@ -129,12 +129,12 @@ export async function installer(): Promise<void> {
   if (DUNE_CACHE) {
     if (platform === Platform.Win32) {
       // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-      const originalPath = process.env.PATH!.split(path.delimiter);
+      const originalPath = process.env["PATH"]!.split(path.delimiter);
       const msys64Path = path.join("C:", "msys64", "usr", "bin");
       const patchedPath = [msys64Path, ...originalPath];
-      process.env.PATH = patchedPath.join(path.delimiter);
+      process.env["PATH"] = patchedPath.join(path.delimiter);
       await restoreDuneCache();
-      process.env.PATH = originalPath.join(path.delimiter);
+      process.env["PATH"] = originalPath.join(path.delimiter);
     } else {
       await restoreDuneCache();
     }