frontend: Log streaming service recommended maximums #11733
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prgmitchell
force-pushed
the
logServiceMaximums
branch
3 times, most recently
from
81d15e2 to
fa436f5
Compare
PatTheMav
reviewed
Jan 17, 2025
Log the maximum recommended audio and video bitrate when the user ticks the "Ignore streaming service setting recommendations" box.
prgmitchell
force-pushed
the
logServiceMaximums
branch
from
fa436f5 to
49a1380
Compare
|
@PatTheMav updated according to your review comments. FYI I have gotten slightly mixed messages around some of this from comments on the previous PR that was approved but your suggestions all made sense. |
No worries, we're in a transitory phase away from "prior art" and towards "new rules", particularly with the frontend refactor PR merged that aims to establish some of those rules. It'll be a bit like pulling teeth for the foreseeable future to get rid of old habits among contributors. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log the maximum recommended audio and video bitrate when the user ticks the "Ignore streaming service setting recommendations" box.
Remake of #10917 because I broke something when rebasing and the commit new commit is not showing.
Motivation and Context
Mentioned by @Warchamp7 that we should warn when a user is going above the recommended bitrate in the loganalyzer, this logging is a requirement to make that happen.
How Has This Been Tested?
Tested Twitch and Youtube in both simple and advanced output mode, both showed the correct values.
Tested with "Custom" to confirm it is showing "None" for audio and video bitrate maximums when those values are returning 0.
https://obsproject.com/logs/ZuadI85OgoP0Yjjj
Types of changes
Checklist: