obs-ffmpeg: Fix throughput checks for older AMD driver #11710
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhutsAMD
force-pushed
the
amf-fix-throughput-query-older-drivers
branch
2 times, most recently
from
c6b4e62 to
2226c62
Compare
Lain-B
approved these changes
Jan 11, 2025
rhutsAMD
force-pushed
the
amf-fix-throughput-query-older-drivers
branch
from
2226c62 to
e9e93a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the case where OBS does not refresh the throughput caps with the user's setting so stale throughput values are used to check preset compatibility as well as the case where
..._CAP_MAX_THROUGHPUTdoes not work as expected -> returns 0 -> and fails to fall back to the lowest preset.Motivation and Context
This is a bug fix.
How Has This Been Tested?
Types of changes
Checklist: