Check that the core-graphics crate does not trigger false-positives. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
commented
Nov 26, 2022
| @@ -129,7 +132,6 @@ jobs: | |||
| uses: actions-rs/toolchain@v1 | |||
| with: | |||
| toolchain: stable | |||
| components: rustfmt, clippy | |||
There was a problem hiding this comment.
We didn't actually use rustfmt or clippy here, so we shouldn't install them.
obi1kenobi
commented
Nov 26, 2022
Comment on lines
-118
to
-119
| # In this particular version, a feature adds an enum variant. | ||
| # Reference: /~https://github.com/obi1kenobi/cargo-semver-check/issues/147 |
There was a problem hiding this comment.
Just moved all the comments describing what's going on to the same place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an integration-style test for
core-graphics, similar to the one we already have forrust-libp2p. Aimed at preventing a regression of #193.