feat: add trait_associated_const_default_removed lint (#888)

* feat: add trait_associated_const_default_removed lint

* fix query

* add lint docs

* remove comments in tests

src/lints/trait_associated_const_default_removed.ron

@@ -0,0 +1,59 @@
+SemverQuery(
+    id: "trait_associated_const_default_removed",
+    human_readable_name: "non-sealed trait removed the default value for an associated constant",
+    description: "A non-sealed trait associated constant lost its default value, which breaks downstream implementations of the trait",
+    required_update: Major,
+    lint_level: Deny,
+    reference_link: Some("https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature"),
+    query: r#"
+    {
+        CrateDiff {
+            current {
+                item {
+                    ... on Trait {
+                        visibility_limit @filter(op: "=", value: ["$public"])
+
+                        importable_path {
+                            path @output @tag
+                            public_api @filter(op: "=", value: ["$true"])
+                        }
+
+                        associated_constant {
+                            associated_constant: name @output @tag
+                            default @filter(op: "is_null") @output
+
+                            span_: span @optional {
+                               filename @output
+                               begin_line @output
+                            }
+                        }
+                    }
+                }
+            }
+            baseline {
+                item {
+                    ... on Trait {
+                        visibility_limit @filter(op: "=", value: ["$public"]) @output
+                        sealed @filter(op: "!=", value: ["$true"])
+
+                        importable_path {
+                            path @filter(op: "=", value: ["%path"])
+                            public_api @filter(op: "=", value: ["$true"])
+                        }
+
+                        associated_constant {
+                            name @filter(op: "=", value: ["%associated_constant"])
+                            default @filter(op: "is_not_null")
+                        }
+                    }
+                }
+            }
+        }
+    }"#,
+    arguments: {
+        "public": "public",
+        "true": true,
+    },
+    error_message: "A non-sealed trait associated constant lost its default value, which breaks downstream implementations of the trait",
+    per_result_error_template: Some("trait constant {{join \"::\" path}}::{{associated_constant}} in file {{span_filename}}:{{span_begin_line}}"),
+)

src/query.rs

@@ -834,6 +834,7 @@ add_lints!(
     struct_repr_transparent_removed,
     struct_with_pub_fields_changed_type,
     trait_associated_const_added,
+    trait_associated_const_default_removed,
     trait_associated_const_now_doc_hidden,
     trait_associated_type_now_doc_hidden,
     trait_default_impl_removed,

test_crates/trait_associated_const_default_removed/new/Cargo.toml

@@ -0,0 +1,7 @@
+[package]
+publish = false
+name = "trait_associated_const_default_removed"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]

test_crates/trait_associated_const_default_removed/new/src/lib.rs

@@ -0,0 +1,36 @@
+mod sealed {
+    pub(crate) trait Sealed {}
+}
+
+pub trait WillLoseDefault {
+    const ONE: bool;
+    fn make_me_non_object_safe() -> Self;
+}
+
+pub trait WillLoseDefaultSealed: sealed::Sealed {
+    const ONE: bool;
+
+    fn make_me_non_object_safe() -> Self;
+}
+
+pub trait Unchanged {
+    const ONE: bool = true;
+
+    fn make_me_non_object_safe() -> Self;
+}
+pub trait UnchangedSealed: sealed::Sealed {
+    const ONE: bool = true;
+
+    fn make_me_non_object_safe() -> Self;
+}
+
+pub trait UnchangedNoDefault {
+    const ONE: bool;
+
+    fn make_me_non_object_safe() -> Self;
+}
+pub trait UnchangedNoDefaultSealed: sealed::Sealed {
+    const ONE: bool;
+
+    fn make_me_non_object_safe() -> Self;
+}

test_crates/trait_associated_const_default_removed/old/Cargo.toml

@@ -0,0 +1,7 @@
+[package]
+publish = false
+name = "trait_associated_const_default_removed"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]

test_crates/trait_associated_const_default_removed/old/src/lib.rs

@@ -0,0 +1,37 @@
+mod sealed {
+    pub(crate) trait Sealed {}
+}
+
+pub trait WillLoseDefault {
+    const ONE: bool = true;
+
+    fn make_me_non_object_safe() -> Self;
+}
+
+pub trait WillLoseDefaultSealed: sealed::Sealed {
+    const ONE: bool = true;
+
+    fn make_me_non_object_safe() -> Self;
+}
+
+pub trait Unchanged {
+    const ONE: bool = true;
+
+    fn make_me_non_object_safe() -> Self;
+}
+pub trait UnchangedSealed: sealed::Sealed {
+    const ONE: bool = true;
+
+    fn make_me_non_object_safe() -> Self;
+}
+
+pub trait UnchangedNoDefault {
+    const ONE: bool;
+
+    fn make_me_non_object_safe() -> Self;
+}
+pub trait UnchangedNoDefaultSealed: sealed::Sealed {
+    const ONE: bool;
+
+    fn make_me_non_object_safe() -> Self;
+}

test_outputs/trait_associated_const_default_removed.output.ron

@@ -0,0 +1,28 @@
+{
+    "./test_crates/trait_associated_const_default_removed/": [
+        {
+            "associated_constant": String("ONE"),
+            "default": Null,
+            "path": List([
+                String("trait_associated_const_default_removed"),
+                String("WillLoseDefault"),
+            ]),
+            "span_begin_line": Uint64(6),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+    ],
+    "./test_crates/trait_items_hidden_from_public_api/": [
+        {
+            "associated_constant": String("DEFAULT_REMOVED"),
+            "default": Null,
+            "path": List([
+                String("trait_items_hidden_from_public_api"),
+                String("NonSealed"),
+            ]),
+            "span_begin_line": Uint64(10),
+            "span_filename": String("src/lib.rs"),
+            "visibility_limit": String("public"),
+        },
+    ],
+}