Skip to content

Commit

Permalink
Upgrade dependencies + Output codenarc version error (#330)
Browse files Browse the repository at this point in the history
* Upgrade node-java-caller

* Upgrade java-caller dependency to 3.2.0 (Now handles Mac M1)

* Use MegaLinter beta

* Build

* Output issue when error colleting CodeNarc version

* Output issue when error collecting CodeNarc version

* build

---------

Co-authored-by: Nicolas Vuillamy <nicolas.vuillamy@cloudity.com>
  • Loading branch information
nvuillam and nvuillam authored Nov 26, 2023
1 parent a8ad083 commit 35d9d1e
Show file tree
Hide file tree
Showing 6 changed files with 109 additions and 47 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/mega-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
# Mega-Linter
- name: Mega-Linter
id: ml
uses: oxsecurity/megalinter/flavors/javascript@v7
uses: oxsecurity/megalinter/flavors/javascript@beta
env:
# All available variables are described in documentation
# https://oxsecurity.github.io/megalinter/#configuration
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## UNRELEASED

## [12.2.0] 2023-11-26

- Upgrade java-caller dependency to 3.2.0 (Now handles Mac M1)
- Output issue when error collecting CodeNarc version

## [12.1.2] 2023-11-23

- Revert update that output json when not requested
Expand Down
9 changes: 9 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@

## UNRELEASED

## [12.2.0] 2023-11-26

- Upgrade java-caller dependency to 3.2.0 (Now handles Mac M1)
- Output issue when error collecting CodeNarc version

## [12.1.2] 2023-11-23

- Revert update that output json when not requested

## [12.1.1] 2023-11-19

- Upgrade node-java-caller to v3.1.1
Expand Down
2 changes: 1 addition & 1 deletion lib/groovy-lint.js
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class NpmGroovyLint {
const v = getNpmGroovyLintVersion();

const codeNarcVersionLinter = await new NpmGroovyLint([process.execPath, "", "--codenarcargs", "-version"], {}).run();
const codeNarcVersionLines = [(await getSourceLines(codeNarcVersionLinter.codeNarcStdOut))[0]];
const codeNarcVersionLines = [(await getSourceLines(codeNarcVersionLinter.codeNarcStdOut || "Error collecting CodeNarc version"))[0]];

const versions = [];
versions.push(`npm-groovy-lint version ${v}`);
Expand Down
136 changes: 92 additions & 44 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"glob": "^7.1.6",
"import-fresh": "^3.2.1",
"ip": "^1.1.5",
"java-caller": "^3.1.1",
"java-caller": "^3.2.0",
"js-yaml": "^4.1.0",
"node-sarif-builder": "^2.0.3",
"optionator": "^0.8.3",
Expand Down

0 comments on commit 35d9d1e

Please sign in to comment.