Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configurable indent marker level #1570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: configurable indent marker level #1570

wants to merge 1 commit into from

Conversation

sand4rt
Copy link
Contributor

@sand4rt sand4rt commented Sep 28, 2024

closes #1512

@sand4rt sand4rt force-pushed the indent-level branch 2 times, most recently from 7f67024 to 86a78c5 Compare September 28, 2024 20:30
@sand4rt sand4rt changed the title feat: configurable indent level feat: configurable marker indent level Sep 29, 2024
@sand4rt sand4rt changed the title feat: configurable marker indent level feat: configurable indent marker level Sep 29, 2024
cseickel
cseickel reviewed Nov 24, 2024
View reviewed changes
Copy link
Contributor

@cseickel cseickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is questionable. I don't know for sure, but other code may assume that level 0 means the root node and this could be more than just a visual tweak.

There is also a padding option on the container which may be more appropriate. Either way, see: #1606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cseickel cseickel cseickel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEATURE: indent marker level
2 participants
@sand4rt @cseickel