fix(renderer): clean out edge cases of cursor.position.restore #1355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be more careful when to save and restore the cursor position as we cannot overwrite the position anymore with #1288.
closes #1310
Please read the LONG discussion from #1354 (comment) as it describes the issue and the reason thoroughly.
I will keep this as draft until I get some people to test this code as I might have missed some more edge cases.
Would you mind testing this code? @georgeguimaraes @mehalter @XavierChanth