Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagnostic): text is nil #1295

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

kawre
Copy link
Contributor

@kawre kawre commented Jan 7, 2024

Copy link
Contributor

@cseickel cseickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix.

One thing I would change would be that if the text lookup fails, I think it would be better to fall back to the first letter of the severity code as the icon instead of just letting it be blank.

@kawre
Copy link
Contributor Author

kawre commented Jan 7, 2024

@cseickel
Copy link
Contributor

cseickel commented Jan 7, 2024

@cseickel Isn't this handled by this function? /~https://github.com/nvim-neo-tree/neo-tree.nvim/blob/396ff81e6bb384b0ef12ae427346cbf97d08f808/lua/neo-tree/sources/common/components.lua#L116C4-L116C4

Yes, it looks like it is. Sorry I didn't remember about that as I was reading the changes.

@cseickel cseickel merged commit c5d2264 into nvim-neo-tree:main Jan 7, 2024
3 checks passed
@kawre kawre deleted the fix-text-is-nil branch January 9, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants