Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can directly specify the path of sdk #354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Decodetalkers
Copy link
Contributor

No description provided.

@Decodetalkers
Copy link
Contributor Author

There are some project like rustup, itself will check the real executable, then run the executable, I have made such kind of project

/~https://github.com/Decodetalkers/flutterup

but if it find the final target called flutterup, the arg0 is flutterup, then it will not redirect to flutter, like what rustup does. and there are also another project do the same thing for flutter, but I have fogotten that project's name

@@ -127,7 +127,7 @@ function M.get(callback)
end

if config.flutter_path then
local flutter_path = fn.resolve(config.flutter_path)
local flutter_path = config.flutter_path
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this could be a breaking change. Would config.flutter_lookup_cmd work for you? If not, perhaps config.flutter_path could be a function. For example:

    local flutter_path = type(config.flutter_path) == "function" and config.flutter_path()
      or fn.resolve(config.flutter_path)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. flutter_lookup_cmd won't work..

why here must be fn.resolve()? I think there is no need..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.. you need it to find dart and etc..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then what about add another config to set flutter sdk manually? I think this way to find flutter sdk is a little weird

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have two configuration options, and introducing a third one might make things more confusing. These two options seem to cover most use cases. I agree that allowing flutter_path to be a function is a bit unconventional, but it serves as an escape hatch for manually providing the path, which I think is a reasonable compromise. Here's an example of how it would look:

{
  flutter_path = function()
    return 'path/to/flutter'
  end
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the thing that I am thinking about is that the way to find the flutter sdk is weird. Find the absolute path of flutter and then find the path of the sdk.. but , yes, it will work for flutter. But does flutter have an official way to get the path of SDK?

@Decodetalkers Decodetalkers changed the title chore: if user set the path then not resolve can directly specify the path of sdk Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants