Sometimes we cannot convert message+args into a formattable string. #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manfred-brands
force-pushed
the
Issue720
branch
from
b84d8e0 to
b84465d
Compare
mikkelbu
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Looks great @manfred-brands. I only have a couple of minor comments/questions. I'm happy to merge it when you are 👍
...nunit.analyzers.tests/ClassicModelAssertUsage/AreEqualClassicModelAssertUsageCodeFixTests.cs
Outdated
Show resolved
Hide resolved
...nunit.analyzers.tests/ClassicModelAssertUsage/AreEqualClassicModelAssertUsageCodeFixTests.cs
Outdated
Show resolved
Hide resolved
...UpdateStringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringAnalyzer.cs
Outdated
Show resolved
Hide resolved
...teStringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringCodeFixTests.cs
Show resolved
Hide resolved
In those case create a string.Format call.
manfred-brands
force-pushed
the
Issue720
branch
from
b84465d to
036b796
Compare
manfred-brands
force-pushed
the
Issue720
branch
from
036b796 to
8e440fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #720
This is on top of #716