Replace make stuff to python stuff
#1613
Conversation
david-ragazzi
force-pushed
the
make_remotion
branch
from
f1d7336 to
585d2fa
Compare
| # Python OPF swarming tests (requires mysql) | ||
| make python_swarming_tests | ||
| # Python unit tests | ||
| python $NUPIC/scripts/run_tests.py -u --coverage |
There was a problem hiding this comment.
Previously we recommended this:
./run_tests.sh ...
If you want to switch to run_tests.py then perhaps we should remove run_tests.sh. Eventually I think we should remove all of the test runners and in the README recommend py.test ... instead since that gives people the most flexibility (and they could use nose or whatever their preferred test runner is).
There was a problem hiding this comment.
I'd like @oxtopus to chime in on this too
There was a problem hiding this comment.
If you want to switch to run_tests.py then perhaps we should remove run_tests.sh.
I also would remove as we want leave the repo more pythonic and cross-platform. It's ok, @oxtopus ?
There was a problem hiding this comment.
I think I'm the only one who still wants run_tests.sh, but I give it up!! 😉
There was a problem hiding this comment.
The run_tests.sh is there because of a policy at Numenta to have consistent entry points for invoking tests.
There was a problem hiding this comment.
The run_tests.sh is there because of a policy at Numenta to have consistent entry points for invoking tests.
setuptools.setup has a entry_points and scripts parameters which allows we specify python scripts to be installed in the system and may be called in everywhere on shell only typing its name. This is the case of nustudio on nupic.studio:
/~https://github.com/nupic-community/nupic.studio/blob/master/setup.py#L37
I simply type nustudio on the shell (not matter from where I call it) and voilá! NuPIC Studio is executed!
I believe that these ones are the right (read default) way to call entry points in Python projects.
There was a problem hiding this comment.
@rhyolight @oxtopus @scottpurdy
Please look this:
#1622
|
I'm closing this and putting the changes into #1622 as it will continue tiny and merge conflicts will be avoided. |
Fixes #1618.
This PR was created to simplify #1579 . Its objective is remove
makestuff as the repository will be fully pythonic.Detailed changes in logic order:
CC: @oxtopus @rhyolight @scottpurdy