Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: container-level version compatibility check for monovertex #2108

Merged
merged 6 commits into from
Oct 2, 2024
Merged

feat: container-level version compatibility check for monovertex #2108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0176430
chore: enable container level version check
KeranYang Sep 30, 2024
de39b43
.
KeranYang Sep 30, 2024
88b435d
.
KeranYang Sep 30, 2024
628ac37
.
KeranYang Oct 1, 2024
7bc6b21
use LazyLock instead of once_cell
KeranYang Oct 1, 2024
24519ef
Merge branch 'main' into rs-gvr
vigith Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rust/numaflow-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ tracing-subscriber = { version = "0.3.18", features = ["env-filter"] }
hyper-util = "0.1.6"
tower = "0.4.13"
uuid = { version = "1.10.0", features = ["v4"] }
once_cell = "1.19.0"
serde_json = "1.0.122"
numaflow-models = { path = "../numaflow-models" }
trait-variant = "0.1.2"
Expand Down
4 changes: 2 additions & 2 deletions rust/numaflow-core/src/monovertex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ mod tests {
let (src_shutdown_tx, src_shutdown_rx) = tokio::sync::oneshot::channel();
let tmp_dir = tempfile::TempDir::new().unwrap();
let src_sock_file = tmp_dir.path().join("source.sock");
let src_info_file = tmp_dir.path().join("source-server-info");
let src_info_file = tmp_dir.path().join("sourcer-server-info");
let server_info_obj = ServerInfo {
protocol: "uds".to_string(),
language: "rust".to_string(),
Expand All @@ -271,7 +271,7 @@ mod tests {
let (sink_shutdown_tx, sink_shutdown_rx) = tokio::sync::oneshot::channel();
let tmp_dir = tempfile::TempDir::new().unwrap();
let sink_sock_file = tmp_dir.path().join("sink.sock");
let sink_server_info = tmp_dir.path().join("sink-server-info");
let sink_server_info = tmp_dir.path().join("sinker-server-info");

write_server_info(sink_server_info.to_str().unwrap(), &server_info_obj)
.await
Expand Down
Loading
Loading