Skip to content

Commit

Permalink
upgrade: refit 8.0 with microsoft dependencies >=8.x #96 (#101)
Browse files Browse the repository at this point in the history
Co-authored-by: todd <todd+github@goneopen.com>
  • Loading branch information
toddb and todd authored Feb 18, 2025
1 parent d5fc4d7 commit 6f64ca1
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 25 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ novu-dotnet targets .NET Standard 2.0 and is compatible with .NET Core 2.0+ and
| 0.3.2 | \>= 0.18 | [BREAKING} Obsolete Notification Templates has been removed. Service registration separation of single client and each client. Novu.Extension and Novu.Sync released as packages. |
| 0.3.2 | \>= 0.18 | |
| 0.4.0 | \>= 0.24 | |
| 0.5.0 | \>= 0.24 | Refit 7.2.2 / Microsoft.Extension>=7.x |
| 0.6.0 | \>= 0.24 | Refit 8.0 / Microsoft.Extension>=8.x |

## Installation

Expand All @@ -51,8 +53,7 @@ dotnet add package Novu
### Direct instantiation

```csharp
using Novu.DTO;
using Novu.Models;
using Novu.Domain.Models;
using Novu;

var novuConfiguration = new NovuClientConfiguration
Expand Down
16 changes: 8 additions & 8 deletions src/Novu.Extensions/Novu.Extensions.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@

<ItemGroup>
<PackageReference Include="JetBrains.Annotations" Version="2024.3.0" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="7.0.0"/>
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="7.0.4"/>
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="7.0.0"/>
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="7.0.0"/>
<PackageReference Include="Microsoft.Extensions.Configuration" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.2" />
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="8.0.1" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="7.0.0"/>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0"/>
<PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="7.0.0" />
<PackageReference Include="Refit.HttpClientFactory" Version="7.2.22" />
<PackageReference Include="System.Configuration.ConfigurationManager" Version="7.0.0" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.2"/>
<PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="8.0.1" />
<PackageReference Include="Refit.HttpClientFactory" Version="8.0.0" />
<PackageReference Include="System.Configuration.ConfigurationManager" Version="8.0.1" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Novu.Sync/Novu.Sync.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<ItemGroup>
<!-- provides the hascode -->
<PackageReference Include="Microsoft.Bcl.HashCode" Version="6.0.0" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="7.0.0"/>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.2" />
</ItemGroup>

<!-- Nuget Assets -->
Expand Down
4 changes: 2 additions & 2 deletions src/Novu.Tests/IntegrationTests/SubscriberPreferenceTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public async Task Should_Get_InApp_Unseen()
var messagesCount = await subscriberClient.GetInAppUnseen(subscriber.SubscriberId!);

// fire forget test, that it returns something
messagesCount.Data.Count.Should().BeGreaterOrEqualTo(0);
messagesCount.Data.Count.Should().BeGreaterThanOrEqualTo(0);
}

[Fact]
Expand All @@ -97,6 +97,6 @@ public async Task Should_Get_InApp()
var messages = await subscriberClient.GetInApp(subscriber.SubscriberId!);

// fire forget test, that it returns something
messages.Data.Should().HaveCountGreaterOrEqualTo(0);
messages.Data.Should().HaveCountGreaterThanOrEqualTo(0);
}
}
20 changes: 10 additions & 10 deletions src/Novu.Tests/Novu.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,25 @@

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="8.0.0"/>
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.0"/>
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="7.0.0"/>
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="7.0.0"/>
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="7.0.0"/>
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0"/>
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.2" />
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="8.0.1" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="8.0.1"/>
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="ParkSquare.Testing.Helpers" Version="8.0.0" />
<PackageReference Include="Polly" Version="8.5.0" />
<PackageReference Include="Refit.HttpClientFactory" Version="7.2.22"/>
<PackageReference Include="Polly" Version="8.5.2" />
<PackageReference Include="Refit.HttpClientFactory" Version="8.0.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="FluentAssertions" Version="7.0.0" />
<PackageReference Include="FluentAssertions" Version="8.0.1" />
<PackageReference Include="Xunit.DependencyInjection" Version="8.9.1" />
<PackageReference Include="Xunit.DependencyInjection.Logging" Version="8.1.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.0">
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="6.0.3">
<PackageReference Include="coverlet.collector" Version="6.0.4">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
4 changes: 2 additions & 2 deletions src/Novu/Novu.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
<!-- Required Nuget Packages -->
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.3"/>
<PackageReference Include="Refit" Version="7.2.22" />
<PackageReference Include="Refit.Newtonsoft.Json" Version="7.2.22" />
<PackageReference Include="Refit" Version="8.0.0" />
<PackageReference Include="Refit.Newtonsoft.Json" Version="8.0.0" />
<PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0"/>
</ItemGroup>

Expand Down

0 comments on commit 6f64ca1

Please sign in to comment.