-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: wallet connect pairing and signing #2956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 1 files 160 suites 6s ⏱️ Results for commit 28c3ff8. ♻️ This comment has been updated with latest results. |
johnthecat
force-pushed
the
fix/wallet-connect-pairing
branch
from
January 14, 2025 08:44
d53d5e9
to
5dab4ed
Compare
Asmadek
approved these changes
Jan 14, 2025
src/renderer/features/wallet-wallet-connect/model/signClient.ts
Outdated
Show resolved
Hide resolved
src/renderer/features/operations/OperationSign/ui/WalletConnect.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2944
Closes #2951
Closes #2954
Closes #2769
Closes #2955
Refactored the pairing and signing logic for WalletConnect integration. Several components were rebuilt from the ground up to better align with WalletConnect v2.0 API specifications.
Also: