Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui: Add config to disable notification silences #228

Merged
merged 3 commits into from
Jan 28, 2025
Merged

gui: Add config to disable notification silences #228

merged 3 commits into from
Jan 28, 2025

Conversation

russellhancox
Copy link
Member

Also fixed a few bugs in SNTTestGUI that made it hard to test this

@russellhancox russellhancox requested a review from a team as a code owner January 27, 2025 21:32
@github-actions github-actions bot added configurator Issues or PRs related to the configurator / Santa configuration comp/santad Issues or PRs related to the daemon comp/gui Issues or PRs related to the Santa GUI lang/objc PRs modifying files in ObjC lang/swift PRs modifying files in Swift comp/common size/m Size: medium labels Jan 27, 2025
@pmarkowsky
Copy link
Contributor

Addresses #227

@pmarkowsky pmarkowsky added this to the 2025.2 milestone Jan 27, 2025
@github-actions github-actions bot added the lang/objc++ PRs modifying files in ObjC++ label Jan 27, 2025
mlw
mlw previously approved these changes Jan 28, 2025
View reviewed changes
@russellhancox russellhancox merged commit 93c27d3 into northpolesec:main Jan 28, 2025
9 of 10 checks passed
@russellhancox russellhancox deleted the rah/config-silences branch January 28, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlw mlw mlw approved these changes

Assignees
No one assigned
Labels
comp/common comp/gui Issues or PRs related to the Santa GUI comp/santad Issues or PRs related to the daemon configurator Issues or PRs related to the configurator / Santa configuration lang/objc PRs modifying files in ObjC lang/objc++ PRs modifying files in ObjC++ lang/swift PRs modifying files in Swift size/m Size: medium
Projects
None yet
Milestone
2025.2
Development

Successfully merging this pull request may close these issues.
3 participants
@russellhancox @pmarkowsky @mlw