Ensure that non-glob faa path patterns are watched

Source/santad/DataLayer/WatchItems.mm

@@ -661,14 +661,26 @@ bool ParseConfig(NSDictionary *config,
       return false;
     }
 
-    for (size_t i = g->gl_offs; i < g->gl_pathc; i++) {
+    // If no paths were returned, check if the search pattern contained any magic
+    // characters. If not, we can go ahead and start monitoring the configured path.
+    if (g->gl_pathc == 0 && ((g->gl_flags & GLOB_MAGCHAR) == 0)) {
       if (item->path_type == WatchItemPathType::kPrefix) {
-        tree_->InsertPrefix(g->gl_pathv[i], item);
+        tree_->InsertPrefix(item->path.c_str(), item);
       } else {
-        tree_->InsertLiteral(g->gl_pathv[i], item);
+        tree_->InsertLiteral(item->path.c_str(), item);
       }
 
-      paths_.insert({g->gl_pathv[i], item->path_type});
+      paths_.insert({item->path.c_str(), item->path_type});
+    } else {
+      for (size_t i = g->gl_offs; i < g->gl_pathc; i++) {
+        if (item->path_type == WatchItemPathType::kPrefix) {
+          tree_->InsertPrefix(g->gl_pathv[i], item);
+        } else {
+          tree_->InsertLiteral(g->gl_pathv[i], item);
+        }
+
+        paths_.insert({g->gl_pathv[i], item->path_type});
+      }
     }
     globfree(g);
   }

Source/santad/DataLayer/WatchItemsTest.mm

@@ -987,6 +987,25 @@ - (void)testState {
   XCTAssertGreaterThanOrEqual(state.last_config_load_epoch, startTime);
 }
 
+- (void)testPathPatternExpectations {
+  NSMutableDictionary *config = WrapWatchItemsConfig(@{
+    @"rule1" : @{kWatchItemConfigKeyPaths : @[ @"abc", @"xyz*" ]},
+  });
+
+  WatchItemsPeer watchItems(@"my_fake_config_path", NULL, NULL);
+  watchItems.ReloadConfig(config);
+
+  // Ensure that non-glob patterns are watched
+  WatchItems::VersionAndPolicies policies = watchItems.FindPolciesForPaths({"abc"});
+  XCTAssertCStringEqual(policies.second[0].value_or(MakeBadPolicy())->name.c_str(), "rule1");
+
+  // Check that patterns with globs are not returned
+  policies = watchItems.FindPolciesForPaths({"xyz"});
+  XCTAssertFalse(policies.second[0].has_value());
+  policies = watchItems.FindPolciesForPaths({"xyzbar"});
+  XCTAssertFalse(policies.second[0].has_value());
+}
+
 - (void)testSetConfigAndSetConfigPath {
   // Test internal state when switching back and forth between path-based and
   // dictionary-based config options.