Use a deque for the ring buffer for better dequeue performance #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the underlying type of the ring buffer to be a
std::deque
. Previously this was astd::vector
. While we had reserved space for the vector which would prevent growth and makeEnqueue
always cheap.Dequeue
ops would still require shifting the items in the vector.std::deque
gets rid of this limitation.There is a tradeoff in memory usage here as
std::deque
will use more. But current use cases only require small ring buffers. If we ever need larger ring buffers, we should move to a more robust ring buffer implementation that manages it's own contiguous memory.