Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove focus-visible polyfill from local dev server #420

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

nolanlawson
Copy link
Owner

All browsers support this now, the polyfill can be de-emphasized.

Copy link

github-actions bot commented Apr 13, 2024

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -2% - +1% (-0.54ms - +0.25ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -4% - +0% (-4.14ms - +0.31ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -3% - +7% (-1.61ms - +3.38ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -3% - +8% (-1.11ms - +3.03ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
33.31ms - 33.55ms-unsure 🔍
-2% - +1%
-0.54ms - +0.25ms
tip-of-tree
tip-of-tree
33.20ms - 33.95msunsure 🔍
-1% - +2%
-0.25ms - +0.54ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
95.18ms - 97.62ms-unsure 🔍
-4% - +0%
-4.14ms - +0.31ms
tip-of-tree
tip-of-tree
96.46ms - 100.17msunsure 🔍
-0% - +4%
-0.31ms - +4.14ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
50.35ms - 53.99ms-unsure 🔍
-3% - +7%
-1.61ms - +3.38ms
tip-of-tree
tip-of-tree
49.58ms - 52.99msunsure 🔍
-6% - +3%
-3.38ms - +1.61ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
37.20ms - 39.93ms-unsure 🔍
-3% - +8%
-1.11ms - +3.03ms
tip-of-tree
tip-of-tree
36.04ms - 39.16msunsure 🔍
-8% - +3%
-3.03ms - +1.11ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

Size Change: 0 B

Total Size: 36.4 kB

ℹ️ View Unchanged
Filename Size
./bundle.js 36.4 kB

compressed-size-action

@nolanlawson nolanlawson merged commit 1cd4b9d into master Apr 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant