Upgrade to cats 0.8.1 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dispalt
commented
Dec 20, 2016
| case ex: TypedPersistentActor.ActorStop => | ||
| x | ||
| x.asInstanceOf[Either[SpecState, (InterpState, Either[ProcException, a])]] |
There was a problem hiding this comment.
Here and below are where I couldn't quite figure out the types
Closed
|
Wow, thanks! I'll have to take a closer look at the SI-2712 thing, but otherwise looks good (I might not get to it until next week, when I'm back from vacation). |
|
I've cleaned up the SI-2712 thing, and merged it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypesInterpretersi2712comment in because I am not sure if I am doing it right.Most of the work was removing the
RecursiveTailRecMinstances since per typelevel/cats#1370 it is now part of the instances