Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: replace NoArrayBufferZeroFillScope with v8 option #56658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 19, 2025

NoArrayBufferZeroFillScope was added before the v8 option to create uninitialized backing stores was added. We can start moving away from it.

There are a handful of remaining instances in src/crypto that I remove in a separate PR. Once both of these land we can remove the NoArrayBufferZeroFillScope class entirely.

NoArrayBufferZeroFillScope was added before the v8 option to
create uninitialized backing stores was added. We can start
moving away from it.
@jasnell jasnell requested review from anonrig and aduh95 January 19, 2025 15:45
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 19, 2025
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (009d53e) to head (78e5b98).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/node_buffer.cc 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56658      +/-   ##
==========================================
- Coverage   89.21%   89.20%   -0.01%     
==========================================
  Files         662      662              
  Lines      191893   191886       -7     
  Branches    36931    36941      +10     
==========================================
- Hits       171196   171179      -17     
  Misses      13541    13541              
- Partials     7156     7166      +10     
Files with missing lines Coverage Δ
src/encoding_binding.cc 79.09% <100.00%> (ø)
src/env.cc 85.80% <100.00%> (-0.16%) ⬇️
src/node_http2.cc 84.79% <100.00%> (-0.04%) ⬇️
src/stream_base.cc 80.33% <100.00%> (-0.04%) ⬇️
src/node_buffer.cc 70.30% <85.71%> (+0.04%) ⬆️

... and 19 files with indirect coverage changes

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants