Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x] deps: revert ABI-breaking change from V8 9.2 #39624

Closed
wants to merge 1 commit into from
Closed

[v16.x] deps: revert ABI-breaking change from V8 9.2 #39624

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 2, 2021

Refs: v8/v8@a7980d4
Refs: v8/v8@ad4eab0
Fixes: #39623

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v16.x v8 engine Issues and PRs related to the V8 dependency. labels Aug 2, 2021
@targos
Copy link
Member Author

targos commented Aug 2, 2021

/cc @addaleax @reuben

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Fast-track has been requested by @targos. Please 👍 to approve.

@targos
Copy link
Member Author

targos commented Aug 2, 2021

I'd like to fast-track this and include it in a small patch release tomorrow.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2021
@targos
Copy link
Member Author

targos commented Aug 2, 2021

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4187/

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 2, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39406/

@targos targos changed the title deps: revert ABI-breaking change from V8 9.2 [v16.x] deps: revert ABI-breaking change from V8 9.2 Aug 2, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 2, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39415/
Green rebuild of fedora-latest-x64: https://ci.nodejs.org/job/node-test-commit-linux/42547/

@targos
Copy link
Member Author

targos commented Aug 2, 2021

Landed in 41e105b

@targos targos closed this Aug 2, 2021
@targos targos deleted the fix-39623 branch August 2, 2021 17:31
targos added a commit that referenced this pull request Aug 2, 2021
@targos
deps: revert ABI-breaking change from V8 9.2
41e105b 
Refs: v8/v8@a7980d4
Refs: v8/v8@ad4eab0
Fixes: #39623

PR-URL: #39624
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos added a commit that referenced this pull request Aug 2, 2021
@targos
deps: revert ABI-breaking change from V8 9.2
3091295 
Refs: v8/v8@a7980d4
Refs: v8/v8@ad4eab0
Fixes: #39623

PR-URL: #39624
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos added a commit that referenced this pull request Aug 2, 2021
@targos
2021-08-03, Version 16.6.1 (Current)
3d53ff8 
Notable changes:

* Updated npm to 7.20.3 (npm team)
  #39579
* Reverted an ABI-breaking change from V8 9.2 that could impact some
  native modules (Michaël Zasso)
  #39624
* Fixed a bug in error handling known to affect at least Webpack and
  Jest (Guy Bedford) #39593

PR-URL: #39631
@targos targos mentioned this pull request Aug 2, 2021
Merged
targos added a commit that referenced this pull request Aug 3, 2021
@targos
2021-08-03, Version 16.6.1 (Current)
51cd4a8 
Notable changes:

* Updated npm to 7.20.3 (npm team)
  #39579
* Reverted an ABI-breaking change from V8 9.2 that could impact some
  native modules (Michaël Zasso)
  #39624
* Fixed a bug in error handling known to affect at least Webpack and
  Jest (Guy Bedford) #39593

PR-URL: #39631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@aduh95 aduh95 aduh95 approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @nodejs-github-bot @addaleax @richardlau @gireeshpunathil @BethGriggs @aduh95 @Flarna