lib: fix typo in lib/_tls_common.js #38129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Apr 7, 2021
aduh95
added
author ready
|
There's no reason to make this one wait the 48 hours to land. Collaborators, please 👍🏻 to fast-track |
lpinca
approved these changes
Apr 7, 2021
This comment has been minimized.
This comment has been minimized.
richardlau
approved these changes
Apr 7, 2021
RaisinTen
approved these changes
Apr 7, 2021
jasnell
approved these changes
Apr 7, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjihrig
approved these changes
Apr 8, 2021
VoltrexKeyva
approved these changes
Apr 8, 2021
`byteLenth` -> `byteLength`. PR-URL: nodejs#38129 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
force-pushed
the
fix/typo-tls-common
branch
from
000048f to
b16e79e
Compare
|
Landed in b16e79e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a typo : "byteLenth" -> "byteLength"