Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

nodejs / node Public

Notifications You must be signed in to change notification settings
Fork 30.3k
Star 109k

Code
Issues 1.6k
Pull requests 499
Discussions
Actions
Projects 2
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

stream: don't emit finish after close#32933

Closed

ronag wants to merge 6 commits intonodejs:masternodejs/node:masterfrom nxtedition:stream-finish-after-closenxtedition/node:stream-finish-after-closeCopy head branch name to clipboard

+46-5

Conversation Commits6 (6)Checks Files changed

Commits

Commits on Apr 25, 2020

stream: don't emit finish after close
ronag
committed
fixup: move on before destroy
ronag
committed
fixup: mustCall
ronag
committed
fixup: move on 'finish'
ronag
committed

Commits on Apr 26, 2020

fixup: closeEmitted not needed on readable, yet
ronag
committed
fixup: remove fixed TODO
ronag
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.