Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test, async_hooks: remove unused param in test-graph.pipe #15007

Closed
wants to merge 1 commit into from
Closed

test, async_hooks: remove unused param in test-graph.pipe #15007

wants to merge 1 commit into from

Conversation

ssbrewster
Copy link
Contributor

@ssbrewster ssbrewster commented Aug 24, 2017 •
edited
Loading

Removes an unused param in test-graph.pipe.js.

Refs: https://twitter.com/NodeTodo/status/900502354834800645

Checklist
Affected core subsystem(s)

test, async_hooks

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Aug 24, 2017
@ssbrewster ssbrewster changed the title test: remove unused param in test-graph.pipe test, async_hooks: remove unused param in test-graph.pipe Aug 24, 2017
vsemozhetbyt
vsemozhetbyt approved these changes Aug 24, 2017
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Trott
Copy link
Member

Trott commented Aug 24, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9828/

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Aug 29, 2017
@ssbrewster @BridgeAR
test: remove unused param in test-graph.pipe
5e443d7 
Refs: https://twitter.com/NodeTodo/status/900502354834800645

PR-URL: nodejs#15007
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR
Copy link
Member

Landed in 5e443d7

@BridgeAR BridgeAR closed this Aug 29, 2017
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@ssbrewster
test: remove unused param in test-graph.pipe
f23d5c2 
Refs: https://twitter.com/NodeTodo/status/900502354834800645

PR-URL: nodejs/node#15007
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@ssbrewster
test: remove unused param in test-graph.pipe
d71817d 
Refs: https://twitter.com/NodeTodo/status/900502354834800645

PR-URL: nodejs/node#15007
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
@ssbrewster @cjihrig
test: remove unused param in test-graph.pipe
167ecee 
Refs: https://twitter.com/NodeTodo/status/900502354834800645

PR-URL: nodejs#15007
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@ssbrewster @MylesBorins
test: remove unused param in test-graph.pipe
fa85f83 
Refs: https://twitter.com/NodeTodo/status/900502354834800645

PR-URL: #15007
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@ssbrewster @MylesBorins
test: remove unused param in test-graph.pipe
5b13add 
Refs: https://twitter.com/NodeTodo/status/900502354834800645

PR-URL: #15007
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@hiroppy hiroppy hiroppy approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ssbrewster @Trott @BridgeAR @refack @jasnell @lpinca @hiroppy @vsemozhetbyt @MylesBorins @nodejs-github-bot