Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ARM64 Windows MSI to Jenkins #3251

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Adding ARM64 Windows MSI to Jenkins #3251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions jenkins/scripts/windows/compile.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,17 @@ if not defined DISABLE_CLCACHE if exist C:\clcache\dist\clcache_main\clcache_mai

:: Call vcbuild
if "%nodes:~-6%" == "-arm64" (
:: Building MSI is not yet supported for ARM64
set "VCBUILD_EXTRA_ARGS=arm64 release"
:: Building MSI is not yet supported for ARM64 with WiX 3.
:: Since PR with WiX 4 migration changed folder structure,
:: this check can determine which WiX is used for the MSI.
:: Refs: /~https://github.com/nodejs/node/pull/45943
if exist tools\msvs\msi\nodemsi.wixproj (
:: WiX 3 - doesn't build ARM64 MSI
set "VCBUILD_EXTRA_ARGS=arm64 release"
) else (
:: WiX 4 - builds ARM64 MSI
set "VCBUILD_EXTRA_ARGS=arm64 %VCBUILD_EXTRA_ARGS%"
)
) else if "%nodes:~-4%" == "-x86" (
set "VCBUILD_EXTRA_ARGS=x86 %VCBUILD_EXTRA_ARGS%"
) else (
Expand Down