fix: correct directory in wasm update #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-ippolito
force-pushed
the
fix/wasm-update
branch
3 times, most recently
from
b9fd333 to
0acc9ee
Compare
|
it seems this is not the right solution |
marco-ippolito
force-pushed
the
fix/wasm-update
branch
from
0acc9ee to
d6ce352
Compare
![github-advanced-security[bot]](/~https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tools/build-wasm.js
Outdated
|
|
||
| try { | ||
| for (const command of commands) { | ||
| execSync(command, { stdio: "inherit" }); |
Check warning
Code scanning / CodeQL
Shell command built from environment values
This autofix suggestion was applied.
Show autofix suggestion
Hide autofix suggestion
This autofix suggestion was applied.
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 months ago
To fix the problem, we should avoid dynamically constructing shell commands with environment values that can be interpreted by the shell. Instead, we should use the execFileSync method to pass the command and its arguments separately, which prevents the shell from interpreting special characters.
Specifically, we need to:
- Split the commands in the
commandsarray into the command and its arguments. - Use
execFileSyncto execute the commands with the arguments passed as an array.
Suggested changeset
1
tools/build-wasm.js
| @@ -67,7 +67,7 @@ | ||
| const commands = [ | ||
| `cd ${wasmBindingPath}`, | ||
| "cargo install --locked wasm-pack", | ||
| "export PATH=/home/node/.cargo/bin:$PATH", | ||
| `sh ${wasmBindingPath}/scripts/build.sh`, | ||
| `cp -r ${wasmBindingPath}/pkg/* ${ROOT}/lib`, | ||
| ["sh", "-c", `cd ${wasmBindingPath}`], | ||
| ["cargo", "install", "--locked", "wasm-pack"], | ||
| ["sh", "-c", "export PATH=/home/node/.cargo/bin:$PATH"], | ||
| ["sh", `${wasmBindingPath}/scripts/build.sh`], | ||
| ["cp", "-r", `${wasmBindingPath}/pkg/*`, `${ROOT}/lib`], | ||
| ]; | ||
| @@ -75,4 +75,4 @@ | ||
| try { | ||
| for (const command of commands) { | ||
| execSync(command, { stdio: "inherit" }); | ||
| for (const [cmd, ...args] of commands) { | ||
| execFileSync(cmd, args, { stdio: "inherit" }); | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
marco-ippolito
committed this autofix suggestion 2 months ago.
marco-ippolito
force-pushed
the
fix/wasm-update
branch
from
d6ce352 to
d6d5576
Compare
…alues Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
@mhdawson I gave it a try but I cannot figure out how to fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: /~https://github.com/nodejs/amaro/actions/runs/11655811754/job/32451022570
@mhdawson